linux-kernel - [PATCH] trivial: drivers/staging/rtl8821ae/rtl8821ae: Fix closing brace followed by if

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Jun 2014 21:56:35 +0200
From:	Rasmus Villemoes <linux@...musvillemoes.dk>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Kosina <trivial@...nel.org>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Rasmus Villemoes <linux@...musvillemoes.dk>
Subject: [PATCH] trivial: drivers/staging/rtl8821ae/rtl8821ae: Fix closing brace followed by if

All of the code is #if 0'd out, and the change just replaces a
space with a newline, so this obviously doesn't change anything.

However, the code is highly suspect: The b_c2h_bt_inquiry_page member
has type bool, and applying the ++ operator to a bool is equivalent to
setting it true (using -- is equivalent to flipping it).

Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
---
 drivers/staging/rtl8821ae/rtl8821ae/hal_btc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hal_btc.c b/drivers/staging/rtl8821ae/rtl8821ae/hal_btc.c
index 7b1d113..b4c68f0 100644
--- a/drivers/staging/rtl8821ae/rtl8821ae/hal_btc.c
+++ b/drivers/staging/rtl8821ae/rtl8821ae/hal_btc.c
@@ -1711,7 +1711,8 @@ void rtl8821ae_dm_bt_inq_page_monitor(struct ieee80211_hw *hw)
 	if (hal_coex_8821ae.b_c2h_bt_inquiry_page) {
 		hal_coex_8821ae.b_c2h_bt_inquiry_page++;
 		// bt inquiry or page is started.
-	} if(hal_coex_8821ae.b_c2h_bt_inquiry_page) {
+	}
+	if(hal_coex_8821ae.b_c2h_bt_inquiry_page) {
 		rtlpcipriv->btcoexist.current_state |= BT_COEX_STATE_BT_INQ_PAGE;
 		if(hal_coex_8821ae.bt_inquiry_page_cnt >= 4)
 			hal_coex_8821ae.bt_inquiry_page_cnt = 0;
-- 
1.9.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/