linux-kernel - Re: [PATCH] x86/mce: Don't unregister CPU hotplug notifier in error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53A496B2.2090701@oracle.com>
Date:	Fri, 20 Jun 2014 16:16:50 -0400
From:	Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:	Borislav Petkov <bp@...en8.de>
CC:	tony.luck@...el.com, linux-kernel@...r.kernel.org,
	linux-edac@...r.kernel.org, mattieu.souchaud@...e.fr
Subject: Re: [PATCH] x86/mce: Don't unregister CPU hotplug notifier in error
 path

On 06/20/2014 04:03 PM, Borislav Petkov wrote:
> On Fri, Jun 20, 2014 at 03:39:34PM -0400, Boris Ostrovsky wrote:
>> What about mce_device_add()?
> What is a mce_device_add()? There's no such function.
>


Sorry, mce_device_create().

We can't call it in the notifier until mcheck_init_device() has been 
successfully executed (we need subsys_system_register(&mce_subsys)). I 
don't know whether we can call subsys_system_register() in mcheck_init() 
-- it is quite early in the boot.

-boris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/