| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 Jun 2014 13:40:27 -0700 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: Rasmus Villemoes <linux@...musvillemoes.dk> Cc: devel@...verdev.osuosl.org, Jiri Kosina <trivial@...nel.org>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] trivial: drivers/staging/rtl8821ae/rtl8821ae: Fix closing brace followed by if On Fri, Jun 20, 2014 at 10:21:45PM +0200, Rasmus Villemoes wrote: > Greg Kroah-Hartman <gregkh@...uxfoundation.org> writes: > > > On Fri, Jun 20, 2014 at 09:56:35PM +0200, Rasmus Villemoes wrote: > >> All of the code is #if 0'd out, and the change just replaces a > >> space with a newline, so this obviously doesn't change anything. > > > > How about just deleting all the #if 0 code out entirely so no one has to > > worry about it anymore? > > Fine by me. Like this? > > From: Rasmus Villemoes <linux@...musvillemoes.dk> > Subject: [PATCH] drivers/staging/rtl8821ae/rtl8821ae: Remove dead code > > This is all #if 0'ed out, and it contains some rather weird stuff > (post-increment of a bool, for example). Nuke it. > > Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk> Looks good, if you send it in a stand-along email, I can even apply it :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists