lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 Jun 2014 14:24:11 -0700 From: Colin Cross <ccross@...roid.com> To: Will Deacon <will.deacon@....com> Cc: "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, Catalin Marinas <Catalin.Marinas@....com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Andrew Morton <akpm@...ux-foundation.org>, "stable@...r.kernel.org" <stable@...r.kernel.org> Subject: Re: [PATCH] ARM64: implement TASK_SIZE_OF On Fri, Jun 20, 2014 at 1:25 AM, Will Deacon <will.deacon@....com> wrote: > Hi Colin, > > On Wed, Jun 18, 2014 at 09:10:09PM +0100, Colin Cross wrote: >> include/linux/sched.h implements TASK_SIZE_OF as TASK_SIZE if it >> is not set by the architecture headers. TASK_SIZE uses the >> current task to determine the size of the virtual address space. >> On a 64-bit kernel this will cause reading /proc/pid/pagemap of a >> 64-bit process from a 32-bit process to return EOF when it reads >> past 0xffffffff. >> >> Implement TASK_SIZE_OF exactly the same as TASK_SIZE with >> test_tsk_thread_flag instead of test_thread_flag. > > Looks sane to me. > > Acked-by: Will Deacon <will.deacon@....com> > > I take it you're being bitten by this in real software, hence the CC stable > tag? > > Will Yes, it causes memory statistics produced by Android's procrank tool to be completely wrong. It applies cleanly to at least 3.10.44, 3.12.22, and 3.14.8. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists