linux-kernel - Fwd: [linux-sunxi] Re: [PATCH v2 17/20] ARM: sunxi: Introduce Allwinner A23 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGb2v65VMBLBf787UmUkmTqhXAZZxSqmFUMwDAWTFtSi7s0yqQ@mail.gmail.com>
Date:	Fri, 20 Jun 2014 13:59:07 +0800
From:	Chen-Yu Tsai <wens@...e.org>
To:	"maxime.ripard" <maxime.ripard@...e-electrons.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	Mike Turquette <mturquette@...aro.org>,
	Emilio Lopez <emilio@...pez.com.ar>,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-serial@...r.kernel.org,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	devicetree <devicetree@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Boris BREZILLON <boris.brezillon@...e-electrons.com>,
	Luc Verhaegen <libv@...net.be>,
	linux-sunxi <linux-sunxi@...glegroups.com>
Subject: Fwd: [linux-sunxi] Re: [PATCH v2 17/20] ARM: sunxi: Introduce
 Allwinner A23 support

On Wed, Jun 18, 2014 at 8:26 PM, Maxime Ripard
<maxime.ripard@...e-electrons.com> wrote:
> On Tue, Jun 17, 2014 at 10:52:54PM +0800, Chen-Yu Tsai wrote:
>> The Allwinner A23 is a dual-core Cortex-A7-based SoC. It re-uses most of
>> the IPs found in previous SoCs, notably the A31.
>>
>> Signed-off-by: Chen-Yu Tsai <wens@...e.org>
>> ---
>>  arch/arm/mach-sunxi/Kconfig |  8 ++++++++
>>  arch/arm/mach-sunxi/sunxi.c | 10 ++++++++++
>>  2 files changed, 18 insertions(+)
>>
>> diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
>> index 0fbd4f1..6434e3b 100644
>> --- a/arch/arm/mach-sunxi/Kconfig
>> +++ b/arch/arm/mach-sunxi/Kconfig
>> @@ -35,4 +35,12 @@ config MACH_SUN7I
>>       select HAVE_ARM_ARCH_TIMER
>>       select SUN5I_HSTIMER
>>
>> +config MACH_SUN8I
>> +     bool "Allwinner A23 (sun8i) SoCs support"
>> +     default ARCH_SUNXI
>> +     select ARCH_HAS_RESET_CONTROLLER
>> +     select ARM_GIC
>> +     select MFD_SUN6I_PRCM
>> +     select RESET_CONTROLLER
>> +
>>  endif
>> diff --git a/arch/arm/mach-sunxi/sunxi.c b/arch/arm/mach-sunxi/sunxi.c
>> index 3f9587b..962ff30 100644
>> --- a/arch/arm/mach-sunxi/sunxi.c
>> +++ b/arch/arm/mach-sunxi/sunxi.c
>> @@ -53,3 +53,13 @@ static const char * const sun7i_board_dt_compat[] = {
>>  DT_MACHINE_START(SUN7I_DT, "Allwinner sun7i (A20) Family")
>>       .dt_compat      = sun7i_board_dt_compat,
>>  MACHINE_END
>> +
>> +static const char * const sun8i_board_dt_compat[] = {
>> +     "allwinner,sun8i-a23",
>> +     NULL,
>> +};
>> +
>> +DT_MACHINE_START(SUN8I_DT, "Allwinner sun8i (A23) Family")
>> +     .init_time      = sun6i_timer_init,
>
> I haven't seen anything in your code that needed to use this
> function. Am I missing something?

(Adding Maxime back to recipients...)

My mistake. From the log I thought all timers needed the reset
controller. Turns out only the high speed timer does.

I'll remove the call in the next version.


ChenYu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/