linux-kernel - [PATCH] staging: cxt1e1: fix sbeCrc function declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20140621172931.GA13116@ThinkPad>
Date:	Sat, 21 Jun 2014 19:29:35 +0200
From:	Pawel Lebioda <pawel.lebioda89@...il.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: [PATCH] staging: cxt1e1: fix sbeCrc function declaration

Hi,

This patch fixes the following sparse warning:

drivers/staging/cxt1e1/sbecrc.c:86:1: warning: symbol 'sbeCrc' was not declared. Should it be static?

Furthermore it fixes wring sbeCrc return type in function declaration.

Regards
Pawel Lebioda

Signed-off-by: Pawel Lebioda <pawel.lebioda89@...il.com>
---
 drivers/staging/cxt1e1/pmcc4.h         | 2 +-
 drivers/staging/cxt1e1/pmcc4_private.h | 1 +
 drivers/staging/cxt1e1/sbecrc.c        | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/cxt1e1/pmcc4.h b/drivers/staging/cxt1e1/pmcc4.h
index b4b5e5a..0220bbf 100644
--- a/drivers/staging/cxt1e1/pmcc4.h
+++ b/drivers/staging/cxt1e1/pmcc4.h
@@ -94,7 +94,7 @@ void        sbecom_set_loglevel (int debuglevel);
 char       *sbeid_get_bdname (ci_t *ci);
 void        sbeid_set_bdtype (ci_t *ci);
 void        sbeid_set_hdwbid (ci_t *ci);
-u_int32_t   sbeCrc (u_int8_t *, u_int32_t, u_int32_t, u_int32_t *);
+void        sbeCrc(u_int8_t *, u_int32_t, u_int32_t, u_int32_t *);
 
 void        VMETRO_TRIGGER (ci_t *, int);       /* Note: int = 0(default)
                                                  * thru 15 */
diff --git a/drivers/staging/cxt1e1/pmcc4_private.h b/drivers/staging/cxt1e1/pmcc4_private.h
index 451f12f..134ddd6 100644
--- a/drivers/staging/cxt1e1/pmcc4_private.h
+++ b/drivers/staging/cxt1e1/pmcc4_private.h
@@ -33,6 +33,7 @@
 #include "musycc.h"
 #include "sbe_promformat.h"
 #include "comet.h"
+#include "sbecom_inline_linux.h"
 
 
 /* driver state */
diff --git a/drivers/staging/cxt1e1/sbecrc.c b/drivers/staging/cxt1e1/sbecrc.c
index a51780f..52d3f71 100644
--- a/drivers/staging/cxt1e1/sbecrc.c
+++ b/drivers/staging/cxt1e1/sbecrc.c
@@ -16,6 +16,7 @@
  */
 
 #include <linux/types.h>
+#include "pmcc4.h"
 #include "pmcc4_sysdep.h"
 #include "sbecom_inline_linux.h"
 #include "sbe_promformat.h"
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/