linux-kernel - Re: [PATCH -tip 1/4] perf/probe: Improve error message for unknown member of data structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+C-WL8PUOOVZCToS+ExtALKUjsHRrnG7zZCFnJWmnLk7n2+4A@mail.gmail.com>
Date:	Sat, 21 Jun 2014 14:18:48 -0400
From:	Patrick Palka <patrick@...cs.ath.cx>
To:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
Cc:	Jiri Olsa <jolsa@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...hat.com>,
	Paul Mackerras <paulus@...ba.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Jiri Olsa <jolsa@...hat.com>, Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH -tip 1/4] perf/probe: Improve error message for unknown
 member of data structure

On Fri, Jun 6, 2014 at 3:13 AM, Masami Hiramatsu
<masami.hiramatsu.pt@...achi.com> wrote:
> Improve the error message if we can not find given member in
> the given structure. Currently perf probe shows a wrong error
> message as below.
>
>   -----
>   # perf probe getname_flags:65 "result->BOGUS"
>   result(type:filename) has no member BOGUS.
>   Failed to find 'result' in this function.
>     Error: Failed to add events. (-22)
>   -----
>
> The first message is correct, but the second one is not, since
> we didn't fail to find a variable but fails to find the member
> of given variable.
>
>   -----
>   # perf probe getname_flags:65 "result->BOGUS"
>   result(type:filename) has no member BOGUS.
>     Error: Failed to add events. (-22)
>   -----
>
> With this patch, the error message shows only the first one.
> And if we really failed to find given variable, it tells us so.
>
>   -----
>   # perf probe getname_flags:65 "BOGUS"
>   Failed to find 'BOGUS' in this function.
>     Error: Failed to add events. (-2)
>   -----
>
> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
> Reported-by: Arnaldo Carvalho de Melo <acme@...nel.org>
> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Cc: Paul Mackerras <paulus@...ba.org>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Cc: Jiri Olsa <jolsa@...hat.com>
> ---
>  tools/perf/util/probe-finder.c |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
> index 9d8eb26..ce8faf4 100644
> --- a/tools/perf/util/probe-finder.c
> +++ b/tools/perf/util/probe-finder.c
> @@ -573,14 +573,13 @@ static int find_variable(Dwarf_Die *sc_die, struct probe_finder *pf)
>         if (!die_find_variable_at(sc_die, pf->pvar->var, pf->addr, &vr_die)) {
>                 /* Search again in global variables */
>                 if (!die_find_variable_at(&pf->cu_die, pf->pvar->var, 0, &vr_die))
> +                       pr_warning("Failed to find '%s' in this function.\n",
> +                                  pf->pvar->var);
>                         ret = -ENOENT;

It looks like you're missing a pair of braces here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/