linux-kernel - Re: [for-next][PATCH v2 1/3] tracing: Fix syscall_*regfunc() vs copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140620211930.29bd1d66@gandalf.local.home>
Date:	Fri, 20 Jun 2014 21:19:30 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	paulmck@...ux.vnet.ibm.com
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Oleg Nesterov <oleg@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [for-next][PATCH v2 1/3] tracing: Fix syscall_*regfunc() vs
 copy_process() race

On Fri, 20 Jun 2014 18:11:25 -0700
"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com> wrote:

> On Fri, Jun 20, 2014 at 06:45:19AM -0400, Steven Rostedt wrote:
> > From: Oleg Nesterov <oleg@...hat.com>
> > 
> > syscall_regfunc() and syscall_unregfunc() should set/clear
> > TIF_SYSCALL_TRACEPOINT system-wide, but do_each_thread() can race
> > with copy_process() and miss the new child which was not added to
> > the process/thread lists yet.
> > 
> > Change copy_process() to update the child's TIF_SYSCALL_TRACEPOINT
> > under tasklist.
> > 
> > Link: http://lkml.kernel.org/p/20140413185854.GB20668@redhat.com
> > 
> > Cc: stable@...r.kernel.org # 2.6.33
> > Fixes: a871bd33a6c0 "tracing: Add syscall tracepoints"
> > Acked-by: Frederic Weisbecker <fweisbec@...il.com>
> > Signed-off-by: Oleg Nesterov <oleg@...hat.com>
> > Signed-off-by: Steven Rostedt <rostedt@...dmis.org>
> 
> Acked-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> 

I don't usually rebase my for-next branch for acks, but I already
rebased once for fixing an issue, and it's early in the rc cycle, and
this is the first patch on the branch, so I think I will do it.

Thanks!

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/