[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20140621.192218.1801115154664681697.davem@davemloft.net>
Date: Sat, 21 Jun 2014 19:22:18 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: grantgrundler@...il.com
Cc: linux@...nbow-software.org, grundler@...isc-linux.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tulip: Poll link status more frequently for Comet chips
From: Grant Grundler <grantgrundler@...il.com>
Date: Sat, 21 Jun 2014 15:59:30 -0700
> Hi Ondrej,
>
> On Sat, Jun 21, 2014 at 1:29 PM, Ondrej Zary <linux@...nbow-software.org> wrote:
>> Poll link status every 2 seconds instead of 60 for ADMtek Comet chips.
>
> Why use 2 seconds for the polling interval?
>
> I'm sure you have a good reason for this and it should be in the
> commit message or as a comment in the code.
>
> I otherwise have no objection to this change.
Agreed, please post this with a better commit message, specifically
make sure you explain why the interval is being changed and why
2*HZ is specifically being choosen.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists