lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <201406221423.15193.marex@denx.de> Date: Sun, 22 Jun 2014 14:23:15 +0200 From: Marek Vasut <marex@...x.de> To: Corentin LABBE <clabbe.montjoie@...il.com> Cc: robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com, ijc+devicetree@...lion.org.uk, galak@...eaurora.org, rdunlap@...radead.org, maxime.ripard@...e-electrons.com, linux@....linux.org.uk, herbert@...dor.apana.org.au, davem@...emloft.net, grant.likely@...aro.org, devicetree@...r.kernel.org, linux-doc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org, linux-sunxi@...glegroups.com Subject: Re: [PATCH v3 1/4] crypto: Add Allwinner Security System crypto accelerator On Sunday, June 22, 2014 at 01:58:08 PM, Corentin LABBE wrote: [...] > >> + * This program is free software; you can redistribute it and/or modify > >> + * it under the terms of the GNU General Public License as published by > >> + * the Free Software Foundation version 2 of the License > > > > The license text seems incomplete. > > [...] > > I will replace it with a simplier line "Licensed under the GPL-2." I'd suggest you to use the SPDX license identifiers then, but that's not something the kernel crowd agreed upon yet IIRC.Therefore , just make the text complete please. [...] > >> + src_addr = kmap(sg_page(in_sg)) + in_sg->offset; > >> + if (src_addr == NULL) { > >> + dev_err(ss->dev, "KMAP error for src SG\n"); > >> + return -1; > >> + } > > > > Why can't you just use dma_map_sg() or somesuch ? > > I do not see why I will use a DMA function in a driver without DMA support. > Perhaps I do not know some tricks. > Can I use writel/readl on address gived by DMA API ? Oh, ok, good question -- dear list, shall one use sg_page()+kmap or sg_virt()? btw. I just noticed you're just feeding the hardware FIFO in a loop with data in the scatterlists, do I understand it correctly ? The driver will consume quite a lot of CPU time to do that, can you not implement DMA here ? [...] Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists