lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1acfd8b6-48f1-4324-9723-224a7f4f7367@default> Date: Sun, 22 Jun 2014 10:25:50 -0700 (PDT) From: Boris Ostrovsky <boris.ostrovsky@...cle.com> To: <bp@...en8.de> Cc: <tony.luck@...el.com>, <mattieu.souchaud@...e.fr>, <linux-edac@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] x86/mce: Don't unregister CPU hotplug notifier in error path ----- bp@...en8.de wrote: > On Fri, Jun 20, 2014 at 10:04:37PM -0400, Boris Ostrovsky wrote: > > I'll try it later but this doesn't look sufficient to me: we might > not > > reach this point if subsys_system_register() or > zalloc_cpumask_var() > > fail. > > If those fail, I'd say we have a much bigger problem than undeleted > timers. You can add Tested-by: Boris Ostrovsky <boris.ostrovsky@...cle.com> if you prefer to go with that version. I still think it's not 100% reliable (because of what I said above) but at least it fixes the current breakage. > > > We could register the notifier as the first thing in this routine > > (probably after mce_available() succeeds). > > I guess... Actually that won't work --- we need to register bus at sysfs first. -boris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists