lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140622184124.GC8053@pengutronix.de> Date: Sun, 22 Jun 2014 20:41:24 +0200 From: Steffen Trumtrar <s.trumtrar@...gutronix.de> To: Thor Thayer <tthayer.linux@...il.com> Cc: Thor Thayer <tthayer@...era.com>, Rob Herring <robherring2@...il.com>, pawel.moll@....com, Mark Rutland <mark.rutland@....com>, ijc+devicetree@...lion.org.uk, Kumar Gala <galak@...eaurora.org>, Rob Landley <rob@...dley.net>, linux@....linux.org.uk, Dinh Nguyen <dinguyen@...era.com>, dougthompson@...ssion.com, Grant Likely <grant.likely@...aro.org>, Borislav Petkov <bp@...en8.de>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, linux-kernel <linux-kernel@...r.kernel.org>, linux-arm-kernel@...ts.infradead.org, linux-edac@...r.kernel.org Subject: Re: [PATCHv6 1/3] devicetree: Addition of the Altera SDRAM controller On Sun, Jun 22, 2014 at 01:31:02PM -0500, Thor Thayer wrote: > On Sat, Jun 21, 2014 at 4:04 AM, Steffen Trumtrar > <s.trumtrar@...gutronix.de> wrote: > > Hi! > > > > On Fri, Jun 20, 2014 at 06:22:01PM -0500, tthayer@...era.com wrote: > >> From: Thor Thayer <tthayer@...era.com> > >> > >> Addition of the Altera SDRAM Controller bindings and device tree changes. > >> > >> v2: Changes to SoC SDRAM EDAC code. > >> > >> v3: Implement code suggestions for SDRAM EDAC code. > >> > >> v4: Remove syscon from SDRAM controller bindings. > >> > >> v5: No Change, bump version for consistency. > >> > >> v6: Only map the ctrlcfg register as syscon. > >> > >> Signed-off-by: Thor Thayer <tthayer@...era.com> > >> --- > >> .../bindings/arm/altera/socfpga-sdram.txt | 11 +++++++++++ > >> arch/arm/boot/dts/socfpga.dtsi | 5 +++++ > >> 2 files changed, 16 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/arm/altera/socfpga-sdram.txt > >> > >> diff --git a/Documentation/devicetree/bindings/arm/altera/socfpga-sdram.txt b/Documentation/devicetree/bindings/arm/altera/socfpga-sdram.txt > >> new file mode 100644 > >> index 0000000..5027026 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/arm/altera/socfpga-sdram.txt > >> @@ -0,0 +1,11 @@ > >> +Altera SOCFPGA SDRAM Controller > >> + > >> +Required properties: > >> +- compatible : "altr,sdr-ctl"; > >> +- reg : Should contain 1 register ranges(address and length) > >> + > >> +Example: > >> + sdrctl@...25000 { > >> + compatible = "altr,sdr-ctl"; > >> + reg = <0xffc25000 0x4>; > >> + }; > >> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi > >> index 4676f25..310292e 100644 > >> --- a/arch/arm/boot/dts/socfpga.dtsi > >> +++ b/arch/arm/boot/dts/socfpga.dtsi > >> @@ -682,6 +682,11 @@ > >> clocks = <&l4_sp_clk>; > >> }; > >> > >> + sdrctl@...25000 { > >> + compatible = "altr,sdr-ctl", "syscon"; > > > > Did you forget to add the syscon to the binding documentation? > > > Hi Steffen, > > I guess I'm confused about when to use syscon. In my last series, I > was advised not to include syscon in the bindings but to use it in the > device tree. I had been including it in the binding document until > this patch. > Oh, aha. Well, then I'm confused, too. Let's wait for one of the DT binding guys than. Regards, Steffen -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists