[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <280704396.67z02n3FAf@myon.chronox.de>
Date: Mon, 23 Jun 2014 09:11:29 +0200
From: Stephan Mueller <smueller@...onox.de>
To: kbuild test robot <fengguang.wu@...el.com>,
Herbert Xu <herbert@...dor.apana.org.au>
Cc: kbuild@...org, linux-kernel@...r.kernel.org,
Dan Carpenter <dan.carpenter@...cle.com>,
Rafael Aquini <aquini@...hat.com>
Subject: [PATCH v2] DRBG: simplify ordering of linked list in drbg_ctr_df
As reported by a static code analyzer, the code for the ordering of
the linked list can be simplified.
Reported-by: kbuild test robot <fengguang.wu@...el.com>
Signed-off-by: Stephan Mueller <smueller@...onox.de>
---
crypto/drbg.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/crypto/drbg.c b/crypto/drbg.c
index faaa2ce..99fa8f8 100644
--- a/crypto/drbg.c
+++ b/crypto/drbg.c
@@ -516,13 +516,13 @@ static int drbg_ctr_df(struct drbg_state *drbg,
S2.next = addtl;
/*
- * splice in addtl between S2 and S4 -- we place S4 at the end of the
- * input data chain
+ * Splice in addtl between S2 and S4 -- we place S4 at the end
+ * of the input data chain. As this code is only triggered when
+ * addtl is not NULL, no NULL checks are necessary.
*/
tempstr = addtl;
- for (; NULL != tempstr; tempstr = tempstr->next)
- if (NULL == tempstr->next)
- break;
+ while (tempstr->next)
+ tempstr = tempstr->next;
tempstr->next = &S4;
/* 10.4.2 step 9 */
--
1.9.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists