linux-kernel - Re: [PATCH 2/2] drivers/net/usb/asix_devices.c: inline ax88772

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1403506697.10017.3.camel@linux-fkkt.site>
Date:	Mon, 23 Jun 2014 08:58:17 +0200
From:	Oliver Neukum <oneukum@...e.de>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Emil Goode <emilgoode@...il.com>, linux-usb@...r.kernel.org
Subject: Re: [PATCH 2/2] drivers/net/usb/asix_devices.c: inline
 ax88772_unbind

On Fri, 2014-06-20 at 22:40 +0200, Fabian Frederick wrote:
> inline this one line function used in driver_info structure

That precisely is this the reason not to inline this.
It is used as a function pointer. gcc must generate
a non-inlined version of the function.

Your patch has zero effect and suggests something that is
actually wrong.

	Regards
		Oliver


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/