linux-kernel - Re: [PATCH] x86: tsc: get rid of custom DIV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140623091818.GO19860@laptop.programming.kicks-ass.net>
Date:	Mon, 23 Jun 2014 11:18:18 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Michal Nazarewicz <mina86@...a86.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: tsc: get rid of custom DIV_ROUND

On Thu, Jun 19, 2014 at 03:58:36AM +0200, Michal Nazarewicz wrote:
> When invoced for positive values, DIV_ROUND macro defined in
> arch/x86/kernel/tsc.c behaves exactly like DIV_ROUND_CLOSEST from
> include/linux/kernel.h file, so remove the custom macro in favour
> of the shared one.

See, I knew we'd had one. _CLOSEST is a dumb postfix though, its the
default whenever people talk of rounding.

> Signed-off-by: Michal Nazarewicz <mina86@...a86.com>
> ---
>  arch/x86/kernel/tsc.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
>  No changes after compilation:
> 
>  $ ll tsc.o.*
>  -rw------- 1 mpn eng 46497 Jun 19 03:54 tsc.o.after
>  -rw------- 1 mpn eng 46497 Jun 19 03:55 tsc.o.before
>  $ objdump -d tsc.o.before >tsc.s.before
>  $ objdump -d tsc.o.after >tsc.s.after
>  $ diff -u tsc.s.before tsc.s.after
>  --- tsc.s.before	2014-06-19 03:56:54.880545041 +0200
>  +++ tsc.s.after	2014-06-19 03:56:54.884545079 +0200
>  @@ -1,5 +1,5 @@
>   
>  -tsc.o.before:     file format elf64-x86-64
>  +tsc.o.after:     file format elf64-x86-64
>   
>   
>   Disassembly of section .text:
>  $

This diff in a diff totally confused patch.

Applies when I remove that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/