linux-kernel - Re: [PATCH v2] ARM: mvebu: rename ARM_ERRATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1403516086.12982.35.camel@x220>
Date:	Mon, 23 Jun 2014 11:34:46 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Jason Cooper <jason@...edaemon.net>, Andrew Lunn <andrew@...n.ch>,
	Gregory CLEMENT <gregory.clement@...e-electrons.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ARM: mvebu: rename ARM_ERRATA_753970

On Mon, 2014-06-23 at 10:07 +0100, Russell King - ARM Linux wrote:
> On Mon, Jun 23, 2014 at 11:01:44AM +0200, Paul Bolle wrote:
> > Dropped the "if CACHE_PL310" fragments used in v1. No need to use "if
> > CACHE_L2X0" instead. Both CACHE_PL310 and CACHE_L2X0 will be
> > (indirectly) selected if MACH_ARMADA_375 or MACH_ARMADA_38X are set.
> 
> Yes there is.  We've recently seen the selection of CACHE_L2X0 be removed
> from platforms, while leaving the selection of the errata behind.  The
> result is Kconfig warnings.  My commit above ensures that this doesn't
> happen in the future by adding the proper dependencies onto those errata
> selects.

The entries I touched read (in summary):
config MACH_MVEBU_V7
        bool
        select CACHE_L2X0

config MACH_ARMADA_370
        bool "Marvell Armada 370 boards" if ARCH_MULTI_V7
        select MACH_MVEBU_V7
        help
          [...].

config MACH_ARMADA_375
        bool "Marvell Armada 375 boards" if ARCH_MULTI_V7
        select MACH_MVEBU_V7
        help
          [...].

So the choice I faced was between: 
- using "select PL310_ERRATA_753970 if CACHE_L2X0": that matches all
  current occurrences of "select PL310_ERRATA_*" but adds a superfluous
  dependency on CACHE_L2X0
- using just "select PL310_ERRATA_753970": sufficient, but will break
  if CACHE_L2X0 isn't selected through MACH_MVEBU_V7 anymore.

I chose to just "select PL310_ERRATA_753970" but adding "if CACHE_L2X0"
is fine with me too.

> Please do the same.

Will do later today.

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/