linux-kernel - Re: [PATCH] arch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53A80215.5090200@gmail.com>
Date:	Mon, 23 Jun 2014 18:31:49 +0800
From:	Chen Gang <gang.chen.5i5j@...il.com>
To:	David Rientjes <rientjes@...gle.com>
CC:	Liqin Chen <liqin.linux@...il.com>,
	Lennox Wu <lennox.wu@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_'
 for related macros


On 06/23/2014 05:38 PM, David Rientjes wrote:
> On Sun, 22 Jun 2014, Chen Gang wrote:
> 
>> diff --git a/arch/score/include/uapi/asm/ptrace.h b/arch/score/include/uapi/asm/ptrace.h
>> index f59771a..7a0ead9 100644
>> --- a/arch/score/include/uapi/asm/ptrace.h
>> +++ b/arch/score/include/uapi/asm/ptrace.h
>> @@ -4,16 +4,16 @@
>>  #define PTRACE_GETREGS		12
>>  #define PTRACE_SETREGS		13
>>  
>> -#define PC		32
>> -#define CONDITION	33
>> -#define ECR		34
>> -#define EMA		35
>> -#define CEH		36
>> -#define CEL		37
>> -#define COUNTER		38
>> -#define LDCR		39
>> -#define STCR		40
>> -#define PSR		41
>> +#define SCORE_PC		32
>> +#define SCORE_CONDITION		33
>> +#define SCORE_ECR		34
>> +#define SCORE_EMA		35
>> +#define SCORE_CEH		36
>> +#define SOCRE_CEL		37
> 
> SOCRE?
> 

OH, typo issue, thanks.

>> +#define SCORE_COUNTER		38
>> +#define SCORE_LDCR		39
>> +#define SCORE_STCR		40
>> +#define SCORE_PSR		41
>>  
>>  #define SINGLESTEP16_INSN	0x7006
>>  #define SINGLESTEP32_INSN	0x840C8000
> 
> This is a uapi header file, what was done to ensure this doesn't introduce 
> userspace breakage?
> 

Do you have any new idea for it, since you have question?


For me, one solving way is: use "#if defined(__KERNEL__) &&
defined(__LINUX__)" for check whether need a prefix (e.g. 'SCORE_') for it.


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/