linux-kernel - Re: [PATCH] video: Remove kfree call since devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53A80B6B.5060805@ti.com>
Date:	Mon, 23 Jun 2014 14:11:39 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Emil Goode <emilgoode@...il.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Jingoo Han <jg1.han@...sung.com>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>
CC:	<linux-fbdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] video: Remove kfree call since devm_kzalloc() is used

On 21/06/14 00:50, Emil Goode wrote:
> We use devm_kzalloc() to allocate memory for the struct vt8500lcd_info
> pointer fbi, so there is no need to free it in vt8500lcd_remove().
> 
> Signed-off-by: Emil Goode <emilgoode@...il.com>
> ---
>  drivers/video/fbdev/vt8500lcdfb.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/video/fbdev/vt8500lcdfb.c b/drivers/video/fbdev/vt8500lcdfb.c
> index a8f2b28..a1134c3 100644
> --- a/drivers/video/fbdev/vt8500lcdfb.c
> +++ b/drivers/video/fbdev/vt8500lcdfb.c
> @@ -474,8 +474,6 @@ static int vt8500lcd_remove(struct platform_device *pdev)
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	release_mem_region(res->start, resource_size(res));
>  
> -	kfree(fbi);
> -
>  	return 0;
>  }
>  
> 

Thanks, queued for 3.17.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)