linux-kernel - Re: [PATCH 1/1] drivers/video/fbdev/sis/sis_main.c: remove unnecessary test on unsigned value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 23 Jun 2014 14:35:05 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Fabian Frederick <fabf@...net.be>, <linux-kernel@...r.kernel.org>
CC:	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>
Subject: Re: [PATCH 1/1] drivers/video/fbdev/sis/sis_main.c: remove unnecessary
 test on unsigned value

On 11/06/14 22:54, Fabian Frederick wrote:
> unsigned value is never < 0
> 
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@...com>
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  drivers/video/fbdev/sis/sis_main.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/video/fbdev/sis/sis_main.c b/drivers/video/fbdev/sis/sis_main.c
> index 22ad028..3f12a2d 100644
> --- a/drivers/video/fbdev/sis/sis_main.c
> +++ b/drivers/video/fbdev/sis/sis_main.c
> @@ -1572,10 +1572,6 @@ sisfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
>  	/* Adapt RGB settings */
>  	sisfb_bpp_to_var(ivideo, var);
>  
> -	/* Sanity check for offsets */
> -	if(var->xoffset < 0) var->xoffset = 0;
> -	if(var->yoffset < 0) var->yoffset = 0;
> -
>  	if(var->xres > var->xres_virtual)
>  		var->xres_virtual = var->xres;
>  
> 

Thanks, queued for 3.17.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)