linux-kernel - Re: linux-next: build failure after merge of the crypto tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 23 Jun 2014 21:40:26 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Tadeusz Struk <tadeusz.struk@...el.com>
Subject: Re: linux-next: build failure after merge of the crypto tree

On Mon, Jun 23, 2014 at 11:15:31PM +1000, Stephen Rothwell wrote:
> Hi Herbert,
> 
> On Mon, 23 Jun 2014 20:27:47 +0800 Herbert Xu <herbert@...dor.apana.org.au> wrote:
> >
> > That's weird as it built correctly here.  This looks like a
> > make/gcc issue as the missing header file is meant to be found
> > with an additional -I.
> > 
> > Could you do a make V=1 for me and show me what the gcc command-line
> > looks like?
> 
> Not until tomorrow.  In the mean time, could you try it with an
> external object dir i.e. "make O=..."
> 
> If that breaks, I think you need to change CURDIR to srcdir or some
> such ...

Thanks for the hint Stephen.  I've added the following fix which
hopefully should fix the problem.

commit e60b244281cfe03ddd7c5c15c4e6b6d6316bb530
Author: Herbert Xu <herbert@...dor.apana.org.au>
Date:   Mon Jun 23 21:37:53 2014 +0800

    crypto: qat - Fix build problem with O=
    
    qat adds -I to the ccflags.  Unfortunately it uses CURDIR which
    breaks when make is invoked with O=.  This patch replaces CURDIR
    with $(src) which should work with/without O=.
    
    Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

diff --git a/drivers/crypto/qat/qat_dh895xcc/Makefile b/drivers/crypto/qat/qat_dh895xcc/Makefile
index 8e4924d..25171c5 100644
--- a/drivers/crypto/qat/qat_dh895xcc/Makefile
+++ b/drivers/crypto/qat/qat_dh895xcc/Makefile
@@ -1,4 +1,4 @@
-ccflags-y := -I$(CURDIR)/drivers/crypto/qat/qat_common
+ccflags-y := -I$(src)/../qat_common
 obj-$(CONFIG_CRYPTO_DEV_QAT_DH895xCC) += qat_dh895xcc.o
 qat_dh895xcc-objs := adf_drv.o \
 		adf_isr.o \

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/