linux-kernel - Re: [PATCH] fs/ntfs: Use '%tx' instead of '%zx'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 23 Jun 2014 11:00:10 +0800
From:	Chen Gang <gang.chen.5i5j@...il.com>
To:	Joe Perches <joe@...ches.com>,
	Anton Altaparmakov <anton@...era.com>
CC:	linux-ntfs-dev@...ts.sourceforge.net,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Liqin Chen <liqin.linux@...il.com>,
	"lennox.wu@...il.com >> Lennox Wu" <lennox.wu@...il.com>
Subject: Re: [PATCH] fs/ntfs: Use '%tx' instead of '%zx'


On 06/23/2014 09:46 AM, Joe Perches wrote:
> Please make sure to cc the specific maintainer
> 
> $ ./scripts/get_maintainer.pl -f fs/ntfs/
> Anton Altaparmakov <anton@...era.com> (supporter:NTFS FILESYSTEM)
> linux-ntfs-dev@...ts.sourceforge.net (open list:NTFS FILESYSTEM)
> linux-kernel@...r.kernel.org (open list)
> 
> (cc'ing Anton)
> 

Yes, I have sent to specific maintainer.


> btw Anton, it seems ntfs_debug does not terminate
> messages with a "\n".  That means that messages
> could be interleaved with other output.
> 
> Maybe this patch as well as Chen Gang's below should be applied
> ---
>  fs/ntfs/debug.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/ntfs/debug.c b/fs/ntfs/debug.c
> index dd6103c..1e824f0 100644
> --- a/fs/ntfs/debug.c
> +++ b/fs/ntfs/debug.c
> @@ -126,7 +126,8 @@ void __ntfs_debug (const char *file, int line, const char *function,
>  	va_start(args, fmt);
>  	vaf.fmt = fmt;
>  	vaf.va = &args;
> -	pr_debug("(%s, %d): %s(): %pV", file, line, flen ? function : "", &vaf);
> +	pr_debug("(%s, %d): %s(): %pV\n",
> +		 file, line, flen ? function : "", &vaf);
>  	va_end(args);
>  }
>  

Hmm... at least, the patch above is fine to me.


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/