linux-kernel - Re: [PATCH] staging: lirc: fix coding style problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1403531657.18747.53.camel@joe-AO725>
Date:	Mon, 23 Jun 2014 06:54:17 -0700
From:	Joe Perches <joe@...ches.com>
To:	Raphael Poggi <poggi.raph@...il.com>
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: lirc: fix coding style problems

On Mon, 2014-06-23 at 15:40 +0200, Raphael Poggi wrote:
> This patch fix some coding style problems.
[]
> diff --git a/drivers/staging/media/lirc/lirc_imon.c b/drivers/staging/media/lirc/lirc_imon.c
[]
> @@ -626,8 +623,8 @@ static void imon_incoming_packet(struct imon_context *context,
>  	if (debug) {
>  		dev_info(dev, "raw packet: ");
>  		for (i = 0; i < len; ++i)
> -			printk("%02x ", buf[i]);
> -		printk("\n");
> +			dev_dbg(dev, "%02x ", buf[i]);
> +		dev_dbg(dev, "\n");

This chunk is not correct and causes output problems.

These printks should either use pr_cont or
you want to use something like print_hex_dump


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/