linux-kernel - Re: [PATCH] trace-cmd: Add missing mode to open() call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140623101917.49037713@gandalf.local.home>
Date:	Mon, 23 Jun 2014 10:19:17 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Seth Forshee <seth.forshee@...onical.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] trace-cmd: Add missing mode to open() call

On Fri, 20 Jun 2014 13:42:29 -0500
Seth Forshee <seth.forshee@...onical.com> wrote:

> touch_file() calls open(2) with O_CREAT but omits the required
> mode argument. Fix this omission.
> 
> Signed-off-by: Seth Forshee <seth.forshee@...onical.com>

Applied, thanks!

-- Steve

> ---
>  trace-record.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/trace-record.c b/trace-record.c
> index d3dd0c5..8438388 100644
> --- a/trace-record.c
> +++ b/trace-record.c
> @@ -1995,7 +1995,7 @@ static void touch_file(const char *file)
>  {
>  	int fd;
>  
> -	fd = open(file, O_WRONLY | O_CREAT | O_TRUNC);
> +	fd = open(file, O_WRONLY | O_CREAT | O_TRUNC, 0644);
>  	if (fd < 0)
>  		die("could not create file %s\n", file);
>  	close(fd);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/