lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 23 Jun 2014 17:44:43 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:	Jaroslav Kysela <perex@...ex.cz>, Jiri Kosina <trivial@...nel.org>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH] trivial: sound/core/seq/seq_memory.c: Fix	closing brace followed by if

At Fri, 20 Jun 2014 21:50:03 +0200,
Rasmus Villemoes wrote:
> 
> Add a newline, and remove a space while at it.

This would give still a checkpatch warning.
Could you fix and resubmit?


thanks,

Takashi

> 
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> ---
>  sound/core/seq/seq_memory.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/core/seq/seq_memory.c b/sound/core/seq/seq_memory.c
> index 1e206de..4854c21 100644
> --- a/sound/core/seq/seq_memory.c
> +++ b/sound/core/seq/seq_memory.c
> @@ -101,7 +101,8 @@ int snd_seq_dump_var_event(const struct snd_seq_event *event,
>  			len -= size;
>  		}
>  		return 0;
> -	} if (! (event->data.ext.len & SNDRV_SEQ_EXT_CHAINED)) {
> +	}
> +	if (!(event->data.ext.len & SNDRV_SEQ_EXT_CHAINED)) {
>  		return func(private_data, event->data.ext.ptr, len);
>  	}
>  
> -- 
> 1.9.2
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@...a-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ