linux-kernel - Re: [PATCH v2] trivial: sound/core/seq/seq_memory.c: Fix closing brace followed by if

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 23 Jun 2014 18:00:55 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:	Jaroslav Kysela <perex@...ex.cz>, Jiri Kosina <trivial@...nel.org>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] trivial: sound/core/seq/seq_memory.c: Fix closing brace followed by if

At Mon, 23 Jun 2014 17:56:09 +0200,
Rasmus Villemoes wrote:
> 
> Add a newline and, while at it, remove a space and redundant braces.
> 
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>

Thanks, applied now.

I usually don't take patches that only do coding style fixes unless
any further real fixes follow, but this case looks like an exception:
the placement of if is actually wrong so it's worth to correct
(although the code could be "else if" there).


Takashi

> ---
>  sound/core/seq/seq_memory.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/core/seq/seq_memory.c b/sound/core/seq/seq_memory.c
> index 1e206de..ba8e4a6 100644
> --- a/sound/core/seq/seq_memory.c
> +++ b/sound/core/seq/seq_memory.c
> @@ -101,9 +101,9 @@ int snd_seq_dump_var_event(const struct snd_seq_event *event,
>  			len -= size;
>  		}
>  		return 0;
> -	} if (! (event->data.ext.len & SNDRV_SEQ_EXT_CHAINED)) {
> -		return func(private_data, event->data.ext.ptr, len);
>  	}
> +	if (!(event->data.ext.len & SNDRV_SEQ_EXT_CHAINED))
> +		return func(private_data, event->data.ext.ptr, len);
>  
>  	cell = (struct snd_seq_event_cell *)event->data.ext.ptr;
>  	for (; len > 0 && cell; cell = cell->next) {
> -- 
> 1.9.2
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/