linux-kernel - Re: [PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53A86C63.7020103@broadcom.com>
Date:	Mon, 23 Jun 2014 11:05:23 -0700
From:	Sherman Yin <syin@...adcom.com>
To:	Sachin Kamat <sachin.kamat@...sung.com>,
	<linux-kernel@...r.kernel.org>
CC:	<linus.walleij@...aro.org>, <spk.linux@...il.com>
Subject: Re: [PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl_probe

Hi Sachin,

Looks good, thanks.  How did you come across the need for this change?

Regards,
Sherman

On 14-06-23 04:38 AM, Sachin Kamat wrote:
> bcm281xx_pinctrl_probe is local to this file. Make it static.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@...sung.com>
> ---
>   drivers/pinctrl/pinctrl-bcm281xx.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-bcm281xx.c b/drivers/pinctrl/pinctrl-bcm281xx.c
> index 3bed792b2c03..c5ca9e633fff 100644
> --- a/drivers/pinctrl/pinctrl-bcm281xx.c
> +++ b/drivers/pinctrl/pinctrl-bcm281xx.c
> @@ -1396,7 +1396,7 @@ static struct pinctrl_desc bcm281xx_pinctrl_desc = {
>   	.owner = THIS_MODULE,
>   };
>
> -int __init bcm281xx_pinctrl_probe(struct platform_device *pdev)
> +static int __init bcm281xx_pinctrl_probe(struct platform_device *pdev)
>   {
>   	struct bcm281xx_pinctrl_data *pdata = &bcm281xx_pinctrl;
>   	struct resource *res;
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/