linux-kernel - Re: [PATCH] usb: gadget: add claimed field in struct usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140623182725.GD5073@saruman.home>
Date:	Mon, 23 Jun 2014 13:27:25 -0500
From:	Felipe Balbi <balbi@...com>
To:	Robert Baldyga <r.baldyga@...sung.com>
CC:	<balbi@...com>, <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<m.szyprowski@...sung.com>, <andrzej.p@...sung.com>
Subject: Re: [PATCH] usb: gadget: add claimed field in struct usb_ep

Hi,

On Mon, Jun 23, 2014 at 08:07:43AM +0200, Robert Baldyga wrote:
> On 06/19/2014 05:08 PM, Felipe Balbi wrote:
> > On Mon, Jun 16, 2014 at 10:20:36AM +0200, Robert Baldyga wrote:
> >> This field allows to mark ep as claimed in more clear way. Claiming
> >> endpoint by setting driver_data to non-null value is leaky solution
> >> and makes code unreadable.
> > 
> > how come ? How can it be unreadable ? how can it be leaky ?
> > 
> 
> What if gadget will not assign any value to driver_data (just like
> Gadget Zero do)? Endpoint will be seen as not used, and autoconfig will

huh ??? The gadget isn't the endpoint user, the function is. Look at
f_sourcesink.c and f_loopback.c. If the function doesn't set anything to
driver_data, then that's a bug on the function which needs fixing.

Moreover, if there's a function which doesn't set driver_data, we could
just as well have a function which doesn't set "claimed", so the problem
is the same.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)