linux-kernel - Re: [PATCH 2/2] lib: list_sort_test(): Add extra corruption check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 23 Jun 2014 21:15:21 +0200
From:	Rasmus Villemoes <linux@...musvillemoes.dk>
To:	Artem Bityutskiy <artem.bityutskiy@...ux.intel.com>
Cc:	Don Mullis <don.mullis@...il.com>,
	Dave Chinner <david@...morbit.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] lib: list_sort_test(): Add extra corruption check

Rasmus Villemoes <linux@...musvillemoes.dk> writes:

> Add a check to make sure that the prev pointer of the list head points
> to the last element on the list.
>
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> ---
>  lib/list_sort.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/lib/list_sort.c b/lib/list_sort.c
> index 291412a..832f525 100644
> --- a/lib/list_sort.c
> +++ b/lib/list_sort.c
> @@ -272,6 +272,11 @@ static int __init list_sort_test(void)
>  		}
>  		count++;
>  	}
> +	if (head->prev != cur) {

Scratch that, should be head.prev. Obviously I forgot TEST_LIST_SORT=y when
test-compiling. Anyway, I have a few other things I'd like to propose
for list_sort.c. Revised patches on their way; sorry for the noise.

Rasmus

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/