linux-kernel - Re: [PATCH] stagging: android: logger: code cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 22 Jun 2014 20:41:54 -0400
From:	Greg KH <greg@...ah.com>
To:	Jerry Stralko <gerb.stralko@...il.com>
Cc:	linux-kernel@...r.kernel.org, swetland@...gle.com
Subject: Re: [PATCH] stagging: android: logger: code cleanup

On Sun, Jun 22, 2014 at 02:51:08PM -0400, Jerry Stralko wrote:
> Add the unlikey macro to the return value of nonseekable_open,
> since it always returns successfully.

That shouldn't be needed, gcc and the processor knows this already.
Don't use unusual unless you can measure it.

> Fixed up some checkpatch warnings.

Don't do more than one thing in a patch, please split this up.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/