linux-kernel - Re: [PATCHv3 0/6] rtlwifi: Fix incorrect MSR mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 24 Jun 2014 00:26:56 +0200
From:	Peter Wu <peter@...ensteyn.nl>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Larry Finger <Larry.Finger@...inger.net>,
	Chaoming Li <chaoming_li@...lsil.com.cn>,
	"John W. Linville" <linville@...driver.com>,
	Ben Hutchings <ben@...adent.org.uk>,
	Mark Cave-Ayland <mark.cave-ayland@...nde.co.uk>,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv3 0/6] rtlwifi: Fix incorrect MSR mask

On Monday 23 June 2014 23:48:16 Rickard Strandqvist wrote:
> An error was found in many rtlwifi drivers where an invalid mask was used,
> (bt_msr & 0xfc) will never match 0x3. This has been corrected by supplying
> a valid mask as a macro. Drivers which did not have this bug are still
> modified for consistency.

LGTM for all 6 patches. Reviewed-by was added with permission in a
private conversation.

> Rickard Strandqvist (1):
>   rtlwifi: Fix media status register mask AND Replace magic number by macro

This looks a bit unfortunate, next time just wipe old patches and
generate new ones with git-format-patch, then use the command
git-send-email patches/*. In that way, the threading stays intact.

Kind regards,
Peter

>  drivers/net/wireless/rtlwifi/rtl8188ee/hw.c  |    2 +-
>  drivers/net/wireless/rtlwifi/rtl8188ee/reg.h |    1 +
>  drivers/net/wireless/rtlwifi/rtl8192ce/hw.c  |    2 +-
>  drivers/net/wireless/rtlwifi/rtl8192ce/reg.h |    1 +
>  drivers/net/wireless/rtlwifi/rtl8192cu/hw.c  |    2 +-
>  drivers/net/wireless/rtlwifi/rtl8192de/hw.c  |    2 +-
>  drivers/net/wireless/rtlwifi/rtl8192de/reg.h |    1 +
>  drivers/net/wireless/rtlwifi/rtl8723ae/hw.c  |    2 +-
>  drivers/net/wireless/rtlwifi/rtl8723ae/reg.h |    1 +
>  drivers/net/wireless/rtlwifi/rtl8723be/hw.c  |    2 +-
>  drivers/net/wireless/rtlwifi/rtl8723be/reg.h |    1 +
>  drivers/staging/rtl8821ae/rtl8821ae/hw.c     |    2 +-
>  drivers/staging/rtl8821ae/rtl8821ae/reg.h    |    1 +
>  13 files changed, 13 insertions(+), 7 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/