linux-kernel - [PATCH] cifs: set null to username and iocharset after being freed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 24 Jun 2014 15:31:41 +0800
From:	Osmond Sun <osmond.sun@...il.com>
To:	sfrench@...ba.org
Cc:	linux-cifs@...r.kernel.org, samba-technical@...ts.samba.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] cifs: set null to username and iocharset after being freed

In function 'expand_dfs_referral' the volume_info->iocharset and
volume_info->username was used after being freed by calling
cleanup_volume_info_contents. Set null to username and iocharset
after being freed.

Signed-off-by: Osmond Sun <osmond.sun@...il.com>
---
 fs/cifs/connect.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 20d75b8..2586a34 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -3251,10 +3251,12 @@ static void
 cleanup_volume_info_contents(struct smb_vol *volume_info)
 {
  kfree(volume_info->username);
+ volume_info->username = NULL;
  kzfree(volume_info->password);
  kfree(volume_info->UNC);
  kfree(volume_info->domainname);
  kfree(volume_info->iocharset);
+ volume_info->iocharset = NULL;
  kfree(volume_info->prepath);
 }

-- 
1.9.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/