linux-kernel - Re: [PATCH 1/1] sound/soc/omap/mcbsp.c: remove unnecessary null test before kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 24 Jun 2014 10:48:25 +0300
From:	Peter Ujfalusi <peter.ujfalusi@...com>
To:	Fabian Frederick <fabf@...net.be>, <linux-kernel@...r.kernel.org>
CC:	Jarkko Nikula <jarkko.nikula@...mer.com>,
	<linux-omap@...r.kernel.org>
Subject: Re: [PATCH 1/1] sound/soc/omap/mcbsp.c: remove unnecessary null test
 before kfree

Hi Fabian,

On 06/23/2014 07:33 PM, Fabian Frederick wrote:
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required

can you send the same patch to alsa-devel with subject:
ASoC: mcbsp:  remove unnecessary null test before kfree

You can add my:
Acked-by: Peter Ujfalusi <peter.ujfalusi@...com>

> 
> Cc: Peter Ujfalusi <peter.ujfalusi@...com>
> Cc: Jarkko Nikula <jarkko.nikula@...mer.com>
> Cc: linux-omap@...r.kernel.org
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  sound/soc/omap/mcbsp.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c
> index 86c7538..68a1252 100644
> --- a/sound/soc/omap/mcbsp.c
> +++ b/sound/soc/omap/mcbsp.c
> @@ -621,8 +621,7 @@ void omap_mcbsp_free(struct omap_mcbsp *mcbsp)
>  	mcbsp->reg_cache = NULL;
>  	spin_unlock(&mcbsp->lock);
>  
> -	if (reg_cache)
> -		kfree(reg_cache);
> +	kfree(reg_cache);
>  }
>  
>  /*
> 


-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/