[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140624084113.GC31390@krava.redhat.com>
Date: Tue, 24 Jun 2014 10:41:14 +0200
From: Jiri Olsa <jolsa@...hat.com>
To: Stanislav Fomichev <stfomichev@...dex-team.ru>
Cc: a.p.zijlstra@...llo.nl, paulus@...ba.org, mingo@...hat.com,
acme@...nel.org, namhyung@...nel.org, artagnon@...il.com,
rusty@...tcorp.com.au, bp@...e.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/4] perf timechart io mode
On Fri, Jun 20, 2014 at 02:29:47PM +0400, Stanislav Fomichev wrote:
> This patchset adds IO mode: instead of process time we record io syscalls
> and then draw timechart of writes/reads/tx/rx/polls.
>
> v4:
> - another attempt for fix segfault when skipping invalid tracepoints
> - added new patch to fix rendering in Firefox
hum, got this when trying:
[jolsa@...va perf]$ sudo ./perf timechart record -I
^C[ perf record: Woken up 2 times to write data ]
[ perf record: Captured and wrote 1.071 MB perf.data (~46806 samples) ]
[jolsa@...va perf]$ ./perf timechart
Invalid previous event (non-zero)!
0x113f80 [0x8]: failed to process type: 68
jirka
>
> v3:
> - fixed segfault when skipping invalid tracepoints
> - added ms/us units support for --io-xyz time options
> - fixed missing boxes on Firefox
>
> v2:
> - separated start_time fix into distinct commit
> - separated --io-xyz options into distinct commit
> - fixed 'error' shadowing
> - initialized variables in declaration when possible
> - removed assert usage
> - fprintf -> pr_err
> - removed wrongly placed __maybe_unused
>
> Stanislav Fomichev (4):
> perf timechart: fix rendering in Firefox
> perf timechart: implement IO mode
> perf timechart: conditionally update start_time on fork
> perf timechart: add more options to IO mode
>
> tools/perf/Documentation/perf-timechart.txt | 38 +-
> tools/perf/builtin-timechart.c | 686 +++++++++++++++++++++++++++-
> tools/perf/util/svghelper.c | 168 +++++--
> tools/perf/util/svghelper.h | 6 +-
> 4 files changed, 838 insertions(+), 60 deletions(-)
>
> --
> 1.8.3.2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists