linux-kernel - Re: [PATCH] sched/idle: Drop !! while calculating 'broadcast'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKohpomVO5H+peZe53U9=cGkRKNB9HVZZe02n+2pByLYJs1G5w@mail.gmail.com>
Date:	Tue, 24 Jun 2014 16:18:26 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Ingo Molnar <mingo@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Lists linaro-kernel <linaro-kernel@...ts.linaro.org>
Subject: Re: [PATCH] sched/idle: Drop !! while calculating 'broadcast'

On 24 June 2014 13:33, Peter Zijlstra <peterz@...radead.org> wrote:
> All true; but does it change anything? That is, does your compiler
> generate better code because of this?

Compilers are smart enough now a days and may not  perform !!
at all I believe.. And so this patch is more about code clarity ..

I tried comparing results for ARM and got this with/without
this patch ..

$ size ../bexynos/kernel/sched/idle.o
   text   data    bss    dec    hex filename
    690     30      0    720    2d0 ../bexynos/kernel/sched/idle.o

Don't know if some architectures are using somewhat dumb
compilers which might result in better code with this patch :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/