linux-kernel - Re: [PATCH 1/1] mfd: pm8921-core: Remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140624121015.GL13803@lee--X1>
Date:	Tue, 24 Jun 2014 13:10:15 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Sachin Kamat <sachin.kamat@...sung.com>
Cc:	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
	davidb@...eaurora.org, spk.linux@...il.com
Subject: Re: [PATCH 1/1] mfd: pm8921-core: Remove unused variable

On Tue, 24 Jun 2014, Sachin Kamat wrote:

> ‘irq_bit’ is unused in the function. Remove it.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@...sung.com>
> ---
> Compile tested.
> ---
>  drivers/mfd/pm8921-core.c |    4 ----
>  1 file changed, 4 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/pm8921-core.c b/drivers/mfd/pm8921-core.c
> index 959513803542..39904f77c049 100644
> --- a/drivers/mfd/pm8921-core.c
> +++ b/drivers/mfd/pm8921-core.c
> @@ -186,11 +186,9 @@ static void pm8xxx_irq_mask_ack(struct irq_data *d)
>  {
>  	struct pm_irq_chip *chip = irq_data_get_irq_chip_data(d);
>  	unsigned int pmirq = irqd_to_hwirq(d);
> -	int	irq_bit;
>  	u8	block, config;
>  
>  	block = pmirq / 8;
> -	irq_bit = pmirq % 8;
>  
>  	config = chip->config[pmirq] | PM_IRQF_MASK_ALL | PM_IRQF_CLR;
>  	pm8xxx_config_irq(chip, block, config);
> @@ -200,11 +198,9 @@ static void pm8xxx_irq_unmask(struct irq_data *d)
>  {
>  	struct pm_irq_chip *chip = irq_data_get_irq_chip_data(d);
>  	unsigned int pmirq = irqd_to_hwirq(d);
> -	int	irq_bit;
>  	u8	block, config;
>  
>  	block = pmirq / 8;
> -	irq_bit = pmirq % 8;
>  
>  	config = chip->config[pmirq];
>  	pm8xxx_config_irq(chip, block, config);

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/