lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <s5hr42ezelj.wl%tiwai@suse.de>
Date:	Tue, 24 Jun 2014 14:17:28 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sound: oss: mpu401.c:  Cleaning up missing break in a case

At Tue, 24 Jun 2014 12:49:35 +0200,
Rickard Strandqvist wrote:
> 
> Added a missed break in a case statement
> 
> This was found using a static code analysis program called cppcheck.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>

Thanks, applied.


Takashi

> ---
>  sound/oss/mpu401.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/oss/mpu401.c b/sound/oss/mpu401.c
> index 25e4609..400896b 100644
> --- a/sound/oss/mpu401.c
> +++ b/sound/oss/mpu401.c
> @@ -316,6 +316,7 @@ static int mpu_input_scanner(struct mpu_config *devc, unsigned char midic)
>  				case 0xf6:
>  					/* printk( "tune_request\n"); */
>  					devc->m_state = ST_INIT;
> +					break;
>  
>  					/*
>  					 *    Real time messages
> -- 
> 1.7.10.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ