lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 Jun 2014 16:58:00 +0100 From: Daniel Thompson <daniel.thompson@...aro.org> To: Nicolas Pitre <nicolas.pitre@...aro.org> CC: Russell King <linux@....linux.org.uk>, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, kgdb-bugreport@...ts.sourceforge.net, patches@...aro.org, linaro-kernel@...ts.linaro.org, John Stultz <john.stultz@...aro.org>, Anton Vorontsov <anton.vorontsov@...aro.org>, Colin Cross <ccross@...roid.com>, kernel-team@...roid.com, Rob Herring <robherring2@...il.com>, Linus Walleij <linus.walleij@...aro.org>, Ben Dooks <ben.dooks@...ethink.co.uk>, Catalin Marinas <catalin.marinas@....com>, Dave Martin <Dave.Martin@....com>, Fabio Estevam <festevam@...il.com>, Frederic Weisbecker <fweisbec@...il.com> Subject: Re: [PATCH v6 1/4] arm: fiq: Add callbacks to manage FIQ routings On 24/06/14 16:44, Nicolas Pitre wrote: > On Tue, 24 Jun 2014, Daniel Thompson wrote: > >> Currently enable_fiq/disable_fiq use a simple offset to convert an IRQ >> virq into a FIQ virq. This is too inflexible for multi-platform kernels >> and makes runtime error checking impossible. >> >> We solve this by introducing a flexible mapping that allows interrupt >> controllers that support FIQ to register those mappings. This, in turn, >> makes it much possible for drivers in DT kernels to install FIQ handlers >> without knowing anything about the interrupt controller. >> >> Signed-off-by: Daniel Thompson <daniel.thompson@...aro.org> >> Cc: Russell King <linux@....linux.org.uk> >> Cc: Fabio Estevam <festevam@...il.com> >> Cc: Nicolas Pitre <nico@...aro.org> >> --- >> arch/arm/include/asm/fiq.h | 7 +++ >> arch/arm/kernel/fiq.c | 103 ++++++++++++++++++++++++++++++++++++++++++++- >> 2 files changed, 108 insertions(+), 2 deletions(-) > > [...] > >> +bool has_fiq(int fiq) >> +{ >> + struct fiq_data *data = lookup_fiq_data(fiq); >> + >> + if (data) >> + return true; >> + >> + if (fiq_start == -1) >> + return false; >> + >> + return fiq > fiq_start; > > Shouldn't this be fiq >= fiq_start ? Absolutely! Will fix that shortly. Thanks Daniel. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists