| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <53A90718.4050401@roeck-us.net> Date: Mon, 23 Jun 2014 22:05:28 -0700 From: Guenter Roeck <linux@...ck-us.net> To: Benjamin Herrenschmidt <benh@...nel.crashing.org> CC: Paul Mackerras <paulus@...ba.org>, linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org, Vincent Guittot <vincent.guittot@...aro.org> Subject: Re: [PATCH] powerpc: Fix build warning On 06/23/2014 09:35 PM, Benjamin Herrenschmidt wrote: > On Fri, 2014-06-13 at 09:38 -0700, Guenter Roeck wrote: >> If compiled with W=1, the following warning is seen in powerpc builds. >> >> arch/powerpc/kernel/smp.c:750:18: warning: >> type qualifiers ignored on function return type >> static const int powerpc_smt_flags(void) >> ^ >> >> This is caused by a function returning 'const int', which doesn't >> make sense to gcc. Drop 'const' to fix the problem. > > This breaks the 64-bit build: > > arch/powerpc/kernel/smp.c:764:2: error: initialization from incompatible pointer type [-Werror] > arch/powerpc/kernel/smp.c:764:2: error: (near initialization for 'powerpc_topology[0].sd_flags') [-Werror] > > It appears that the generic definition in sched.h has this function > defined as const int, so that needs to be fixed too along with all > instances in all archs. > https://lkml.org/lkml/2014/6/12/743 Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists