linux-kernel - Re: [PATCH v8] NVMe: convert to blk-mq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53A9CF5F.6040806@bjorling.me>
Date:	Tue, 24 Jun 2014 21:19:59 +0200
From:	Matias Bjorling <m@...rling.me>
To:	Keith Busch <keith.busch@...el.com>
CC:	willy@...ux.intel.com, sbradshaw@...ron.com, axboe@...com,
	tom.leiming@...il.com, hch@...radead.org,
	linux-kernel@...r.kernel.org, linux-nvme@...ts.infradead.org
Subject: Re: [PATCH v8] NVMe: convert to blk-mq

Den 16-06-2014 17:57, Keith Busch skrev:
> On Fri, 13 Jun 2014, Matias Bjørling wrote:
>> This converts the current NVMe driver to utilize the blk-mq layer.
>
>> static void nvme_reset_notify(struct pci_dev *pdev, bool prepare)
>> {
>> -       struct nvme_dev *dev = pci_get_drvdata(pdev);
>> +    struct nvme_dev *dev = pci_get_drvdata(pdev);
>>
>> -       if (prepare)
>> -               nvme_dev_shutdown(dev);
>> -       else
>> -               nvme_dev_resume(dev);
>> +    spin_lock(&dev_list_lock);
>> +    if (prepare)
>> +        list_del_init(&dev->node);
>> +    else
>> +        list_add(&dev->node, &dev_list);
>> +    spin_unlock(&dev_list_lock);
>> }
>> +        if (nvme_create_queue(dev->queues[i], i))
>>             break;
>> }
>
> The above change was just error injection test code so you can cause
> a device to become unresponsive and trigger the timeout handling.
>
> This latest is otherwise stable on my dev machine.

May I add an Acked-by from you?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/