linux-kernel - Re: [PATCH 1/1] ar7: replace mac address parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Jun 2014 12:26:15 -0700
From:	Florian Fainelli <florian@...nwrt.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Daniel Walter <dwalter@...gle.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Linux-MIPS <linux-mips@...ux-mips.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] ar7: replace mac address parsing

2014-06-24 8:48 GMT-07:00 Joe Perches <joe@...ches.com>:
> On Tue, 2014-06-24 at 16:39 +0100, Daniel Walter wrote:
>> Replace sscanf() with mac_pton().
> []
>> diff --git a/arch/mips/ar7/platform.c b/arch/mips/ar7/platform.c
> []
>> @@ -307,10 +307,7 @@ static void __init cpmac_get_mac(int instance, unsigned char *dev_addr)
>>       }
>>
>>       if (mac) {
>> -             if (sscanf(mac, "%hhx:%hhx:%hhx:%hhx:%hhx:%hhx",
>> -                                     &dev_addr[0], &dev_addr[1],
>> -                                     &dev_addr[2], &dev_addr[3],
>> -                                     &dev_addr[4], &dev_addr[5]) != 6) {
>> +             if (!mac_pton(mac, dev_addr)) {
>
> There is a slight functional change with this conversion.
>
> mac_pton is strict about leading 0's and requires a 17 char strlen.

I do not have my devices handy, but I am fairly positive the use of
sscanf() was exactly for that, we may or may not have leading zeroes.
I am feeling a little uncomfortable with random code changes like that
without being actually able to test on real hardware that has a
variety of bootloaders and environment variables.

>
> sscanf will accept 0:1:2:3:4:5, mac_pton will not.
>
>>                       pr_warning("cannot parse mac address, "
>>                                       "using random address\n");
>
> could be coalesced and pr_warn
>
>                         pr_warn("cannot parse mac address - using random address\n");
>
>
>



-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/