linux-kernel - Re: [RFC PATCH 0/3] Mark literal strings in __init / _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1403646310.29061.61.camel@joe-AO725>
Date:	Tue, 24 Jun 2014 14:45:10 -0700
From:	Joe Perches <joe@...ches.com>
To:	Mathias Krause <minipli@...glemail.com>
Cc:	Rasmus Villemoes <linux@...musvillemoes.dk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [RFC PATCH 0/3] Mark literal strings in __init / __exit code

On Tue, 2014-06-24 at 23:06 +0200, Mathias Krause wrote:
> On 24 June 2014 22:57, Joe Perches <joe@...ches.com> wrote:
> > On Tue, 2014-06-24 at 22:41 +0200, Mathias Krause wrote:
> >> And all of those strings should be in the .rodata section, now. But
> >> why you're asking?
> > Because now they will be duplicated in .rodata
> > and the __init section no?
> No. A string marked with __init_str() will only life in the
> .init.rodata section. No duplication.

Unless the same string is used in another bit
of code.  Then there's duplication.

> Having duplicated strings in .rodata and .init.rodata is also no
> problem as the latter will be freed.

They increase image size.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/