linux-kernel - Re: [PATCH v8] NVMe: convert to blk-mq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.03.1406241531350.4699@AMR>
Date:	Tue, 24 Jun 2014 15:47:11 -0600 (MDT)
From:	Keith Busch <keith.busch@...el.com>
To:	Matias Bjørling <m@...rling.me>
cc:	Keith Busch <keith.busch@...el.com>,
	Matthew Wilcox <willy@...ux.intel.com>,
	"Sam Bradshaw (sbradshaw)" <sbradshaw@...ron.com>,
	Jens Axboe <axboe@...com>, Ming Lei <tom.leiming@...il.com>,
	Christoph Hellwig <hch@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-nvme <linux-nvme@...ts.infradead.org>
Subject: Re: [PATCH v8] NVMe: convert to blk-mq

On Tue, 24 Jun 2014, Matias Bjørling wrote:
> On Tue, Jun 24, 2014 at 10:33 PM, Keith Busch <keith.busch@...el.com> wrote:
>> On Tue, 24 Jun 2014, Matias Bjorling wrote:
>>> Den 16-06-2014 17:57, Keith Busch skrev:
>>>>
>>>> This latest is otherwise stable on my dev machine.
>>>
>>> May I add an Acked-by from you?
>>
>> Totally up to Willy, but my feeling is "not just yet". I see the value
>> this driver provides, but I would need to give this to a customer and
>> hear their results before adding an "ack". It maybe a couple more weeks
>> before they'll be able to try it.
>
> I was hoping to get an OK before that, to make sure it is picked up
> for the 3.17 release.
>
> Should I pack it up in a specific way to help it along?

I think what you're doing is the right way to go. I trust you removed
the test code from your next iteration, and this does pass my tests on my
machine... I was just hoping to hear what some other people with better
macro level benchmarking abilities would say. So okay, you can put my
"Acked-by" on this, but I don't have all the performance numbers yet.