linux-kernel - Re: [PATCH] mm/vmalloc.c: add a schedule point to vmalloc()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1406241517560.29176@chino.kir.corp.google.com>
Date:	Tue, 24 Jun 2014 15:18:57 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Hugh Dickins <hughd@...gle.com>
Subject: Re: [PATCH] mm/vmalloc.c: add a schedule point to vmalloc()

On Tue, 24 Jun 2014, Eric Dumazet wrote:

> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index f64632b67196..05a145ed1332 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -1602,6 +1602,7 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask,
>  			goto fail;
>  		}
>  		area->pages[i] = page;
> +		cond_resched();
>  	}
>  
>  	if (map_vm_area(area, prot, &pages))

Now that we pass the gfp mask into vmalloc() and all allocations aren't 
inherently GFP_KERNEL, I think this should only be done for (gfp_mask & 
__GFP_WAIT).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/