linux-kernel - Re: [PATCH 1/2] regulator: max1586 add device-tree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140624231528.GV23300@sirena.org.uk>
Date:	Wed, 25 Jun 2014 00:15:28 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Robert Jarzmik <robert.jarzmik@...e.fr>
Cc:	Liam Girdwood <lgirdwood@...il.com>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] regulator: max1586 add device-tree support

On Tue, Jun 24, 2014 at 08:05:30PM +0200, Robert Jarzmik wrote:
> Mark Brown <broonie@...nel.org> writes:

> >> As for the "state report", this max1586 doesn't report anything, it cannot even
> >> be queried about the current voltage, sic ...

> > It can't?  That's unfortunate, though I was able to turn up a datasheet
> > which appears to support that.

> Oh really ? Well, tell me where you read it.

I said I *was* able to turn up a datasheet which appeared to support
that.

> >> If you want me to modify this bit I need a bit more of an explanation to
> >> understand.

> > Where the driver is doing unusual things if they are actually sensible
> > then the change needs to be clearer about why.

> So would a comment like this address your comment ?

> 	/* Either matched < 0 and return the error. Or matched is 0 which means
> 	 * no init data was found, ie. no regulator is configured, and return 0
> 	 * to caller, stating neither error nor any matched regulator.
> 	 */
> 	if (matched <= 0)
> 		return matched;

Can you include something like "...and we have no readback support in
the device so can't report status" or something please?  That's the key
bit - the point is that even unconfigured regulators should normally be
registered.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)