linux-kernel - Re: [PATCH v2] rch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53AA251D.9070100@gmail.com>
Date:	Wed, 25 Jun 2014 09:25:49 +0800
From:	Chen Gang <gang.chen.5i5j@...il.com>
To:	David Rientjes <rientjes@...gle.com>,
	Guenter Roeck <linux@...ck-us.net>
CC:	Liqin Chen <liqin.linux@...il.com>,
	Lennox Wu <lennox.wu@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] rch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_'
 for related macros

On 06/25/2014 07:40 AM, David Rientjes wrote:
> On Tue, 24 Jun 2014, Guenter Roeck wrote:
> 
>> That is another question. But for the time being it might be sufficient to
>> surround the defines with #if !defined(__KERNEL__) without introducing new
>> (and unused) kernel defines.
>>
> 
> On the other hand, if no userspace is referencing these, then you could 
> just rename them and move them out of the uapi header to 
> include/asm/ptrace.h and be done with it.
> 

OK, thanks. And sorry for the subject lost 'a', firstly.  And it is
related with UAPI,  so it is really important enough to let related
maintainer to notice about it.

I guess, only the related maintainer know whether can remove these
macros out of "include/uapi/asm/ptrace.h" (although in current upstream
kernel source, they are really not used).

It is abnormal in uapi headers for same values with different macros
switched by "__KERNEL__", but if we have to remain them still in uapi,
we have to use "__KERNEL__ && __linux__" to carm down kernel and user.

Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/