linux-kernel - Re: [PATCH] arch: x86: kvm: x86.c: Cleaning up variable is set more than once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53AAC015.1060507@redhat.com>
Date:	Wed, 25 Jun 2014 14:27:01 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Gleb Natapov <gleb@...nel.org>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arch: x86: kvm: x86.c:  Cleaning up variable is set more
 than once

Il 25/06/2014 14:25, Rickard Strandqvist ha scritto:
> A struct member variable is set to the same value more than once
>
> This was found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
>  arch/x86/kvm/x86.c |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index f32a025..0f48eb7 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -4730,7 +4730,6 @@ static void emulator_set_segment(struct x86_emulate_ctxt *ctxt, u16 selector,
>  	if (desc->g)
>  		var.limit = (var.limit << 12) | 0xfff;
>  	var.type = desc->type;
> -	var.present = desc->p;
>  	var.dpl = desc->dpl;
>  	var.db = desc->d;
>  	var.s = desc->s;
>

Thanks, applying this patch.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/