linux-kernel - Re: [PATCH] sound: oss: mpu401.c: Cleaning up variable is set more than once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h4mz9xj8k.wl%tiwai@suse.de>
Date:	Wed, 25 Jun 2014 14:32:27 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Jaroslav Kysela <perex@...ex.cz>,
	Julia Lawall <Julia.Lawall@...6.fr>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sound: oss: mpu401.c:  Cleaning up variable is set more than once

At Wed, 25 Jun 2014 14:18:24 +0200,
Rickard Strandqvist wrote:
> 
> A struct member variable is set to the same value more than once
> 
> This was found using a static code analysis program called cppcheck.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>

Applied, thanks.


Takashi

> ---
>  sound/oss/mpu401.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/sound/oss/mpu401.c b/sound/oss/mpu401.c
> index 3bbc3ec..31d7f72 100644
> --- a/sound/oss/mpu401.c
> +++ b/sound/oss/mpu401.c
> @@ -972,7 +972,6 @@ int attach_mpu401(struct address_info *hw_config, struct module *owner)
>  	devc->m_busy = 0;
>  	devc->m_state = ST_INIT;
>  	devc->shared_irq = hw_config->always_detect;
> -	devc->irq = hw_config->irq;
>  	spin_lock_init(&devc->lock);
>  
>  	if (devc->irq < 0)
> -- 
> 1.7.10.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/