linux-kernel - Re: [PATCH] scsi: pm8001: pm80xx_hwi.c: Cleaning up variable is set more than once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <53AAF3F0.3010700@redhat.com>
Date:	Wed, 25 Jun 2014 18:08:16 +0200
From:	Maurizio Lombardi <mlombard@...hat.com>
To:	Purush Gupta <purush.gupta@...anix.com>
CC:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	xjtuwjp@...il.com, lindar_liu@...sh.com,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	linux-scsi@...r.kernel.org,
	Linux Kernel List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: pm8001: pm80xx_hwi.c: Cleaning up variable is set
 more than once

Hi,

On 06/25/2014 05:41 PM, Purush Gupta wrote:
> Its possible HW may require programming those fields?

I'm looking at the code and it doesn't look so, did you see something suspicious?

> May be original
> contributor of the driver should review...No offense!

I believe it requires the maintainer ACK and it takes precedence in any case, am I wrong?

Regards,
Maurizio Lombardi

> 
> thanks,
> Purush
> 
> 
> On Wed, Jun 25, 2014 at 8:34 AM, Maurizio Lombardi <mlombard@...hat.com>
> wrote:
> 
>> This one looks good to me,
>>
>> Reviewed-by: Maurizio Lombardi <mlombard@...hat.com>
>>
>> On 06/25/2014 04:01 PM, Rickard Strandqvist wrote:
>>> A struct member variable is set to different values without having used
>> in between.
>>>
>>> This was found using a static code analysis program called cppcheck
>>>
>>> Signed-off-by: Rickard Strandqvist <
>> rickard_strandqvist@...ctrumdigital.se>
>>> ---
>>>  drivers/scsi/pm8001/pm80xx_hwi.c |    1 -
>>>  1 file changed, 1 deletion(-)
>>>
>>> diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c
>> b/drivers/scsi/pm8001/pm80xx_hwi.c
>>> index d70587f..2698227 100644
>>> --- a/drivers/scsi/pm8001/pm80xx_hwi.c
>>> +++ b/drivers/scsi/pm8001/pm80xx_hwi.c
>>> @@ -249,7 +249,6 @@ moreData:
>>>                               sprintf(pm8001_ha->
>>>                                       forensic_info.data_buf.direct_data,
>>>                                               "%08x ", 4);
>>> -                     pm8001_ha->forensic_info.data_buf.read_len =
>> 0xFFFFFFFF;
>>>                       pm8001_ha->forensic_info.data_buf.direct_len =  0;
>>>                       pm8001_ha->forensic_info.data_buf.direct_offset =
>> 0;
>>>                       pm8001_ha->forensic_info.data_buf.read_len = 0;
>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/