linux-kernel - Re: [hch-scsi-queue:core-for-3.17 18/27] drivers/staging/rts5208/rtsx.c:468:5: warning: format '%d' expects argument of type 'int', but argument 4 has type 'u64'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140625162322.GA8121@localhost>
Date:	Thu, 26 Jun 2014 00:23:22 +0800
From:	Fengguang Wu <fengguang.wu@...el.com>
To:	Christoph Hellwig <hch@....de>,
	Micky Ching <micky_ching@...lsil.com.cn>
Cc:	Hannes Reinecke <hare@...e.de>, linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [hch-scsi-queue:core-for-3.17 18/27]
 drivers/staging/rts5208/rtsx.c:468:5: warning: format '%d' expects argument
 of type 'int', but argument 4 has type 'u64'

Hi Christoph,

On Wed, Jun 25, 2014 at 05:41:40PM +0200, Christoph Hellwig wrote:
> Fengguang,
> 
> can you change the kbuild robot to only send warnings in the staging
> drivers to the maintainers of those, and not people changing core code?

The rule is currently CC the first bad commit's author and committer.
In this case,

        commit 4184a1e415257e3d2e75a5adf184de9ffaf82a7c
        Author:     Hannes Reinecke <hare@...e.de>
        AuthorDate: Wed Jun 25 15:27:36 2014 +0200
        Commit:     Christoph Hellwig <hch@....de>
        CommitDate: Wed Jun 25 16:21:45 2014 +0200

            scsi: use 64-bit LUNs

=>

        TO: Hannes Reinecke <hare@...e.de>
        CC: Christoph Hellwig <hch@....de>

Do you mean adding rule

        if error_file =~ /drivers\/staging/
                TO/CC error_file's author/committer instead
        end

In this case,

        TO: Micky Ching <micky_ching@...lsil.com.cn>
        CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

I agree that it'd be good for Micky to work out a fix for his staging
driver. However due to the obvious dependency here, it looks best for
you to include the fix together with "scsi: use 64-bit LUNs"?

So in general it'd be good to keep all relevant people in the CC list.
That is,

        TO/CC first bad commit's author/committer
        for each error_file =~ /drivers\/staging/
                CC error_file's author/committer
        end

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/