linux-kernel - [PATCH] tools: msgque improve error handling when not running as root

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1403725210-10245-1-git-send-email-shuah.kh@samsung.com>
Date:	Wed, 25 Jun 2014 13:40:10 -0600
From:	Shuah Khan <shuah.kh@...sung.com>
To:	gregkh@...uxfoundation.org, akpm@...ux-foundation.org,
	davidlohr@...com, colin.king@...onical.com
Cc:	Shuah Khan <shuah.kh@...sung.com>, linux-kernel@...r.kernel.org
Subject: [PATCH] tools: msgque improve error handling when not running as root

The test fails in the middle when it is not run as root while
accessing /proc/sys/kernel/msg_next_id. Changed it to check
for root at the beginning of the test. Also added messages
to indicate start and test pass status.

Signed-off-by: Shuah Khan <shuah.kh@...sung.com>
---
 tools/testing/selftests/ipc/msgque.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tools/testing/selftests/ipc/msgque.c b/tools/testing/selftests/ipc/msgque.c
index aa290c0..30c627a 100644
--- a/tools/testing/selftests/ipc/msgque.c
+++ b/tools/testing/selftests/ipc/msgque.c
@@ -193,6 +193,12 @@ int main(int argc, char **argv)
 	int msg, pid, err;
 	struct msgque_data msgque;
 
+	if (getuid() != 0) {
+		fprintf(stderr, "Please run the test as root - Exiting.\n");
+		exit(1);
+	}
+
+	printf("Starting ipc tests:\n");
 	msgque.key = ftok(argv[0], 822155650);
 	if (msgque.key == -1) {
 		printf("Can't make key\n");
@@ -235,6 +241,7 @@ int main(int argc, char **argv)
 		printf("Failed to test queue\n");
 		goto err_out;
 	}
+	printf("All ipc tests Passsed\n");
 	return 0;
 
 err_destroy:
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/